Ensure that the context enrich function doesn't overwrite existing variables #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djbe
force-pushed
the
feature/merge-context
branch
from
f6675c7
to
34d7af5
Compare
AliSoftware
reviewed
Mar 24, 2017
Sources/Context.swift
Outdated
| context[StencilContext.environment] = environment | ||
| context[StencilContext.parameters] = try Parameters.parse(items: parameters) | ||
| context[self.environment] = merge(context[self.environment], with: environment) | ||
| context[self.parameters] = merge(context[self.parameters], with: try Parameters.parse(items: parameters)) |
There was a problem hiding this comment.
Maybe we should rename those two static let constants using environmentKey and parametersKey.
Because the first time i read and reviewed your code change I didn't understand why you used instance properties there, and almost thought that self.environment were referring to the [String: String] dictionary of the context, containing the env variables (ok, doing the review from GitHub didn't help, as the limited git diff scope failed to remind me that this was actually inside a static func…). Using context[self.paramtersKey] should help clarify that.
AliSoftware
reviewed
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for SwiftGen/SwiftGenKit#13